[Kdenlive-devel] Fwd: Review Request 119095: GUI Added the vid.stab video stabilizer as a menu option.

[Vincent PINON]

Hello,

Sorry for the late reaction;
Patch applied to activate vid.stab, on git master (stable) branch.

Please test and comment ; do we need to keep older stab filters ? (for
projects compatibility)

BR,

Vincent


-------- Message original --------
Sujet: Review Request 119095: GUI Added the vid.stab video stabilizer
as a menu option.
Date : Thu, 03 Jul 2014 21:48:13 -0000
De : Steve Guilford <***@dbplugins.com>
Répondre à : Steve Guilford <***@dbplugins.com>
Pour : Vincent Pinon <***@laposte.net>
Copie à : Steve Guilford <***@dbplugins.com>



This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119095/


Review request for Vincent Pinon.
By Steve Guilford.
*Repository: * kdenlive


Description

GUI Added menu option for new video stabilizer "vid.stab". Duplicated screen for videostab2 stabilizer for use with vid.stab.


Testing

Tested w/ current dev branch of Kdenlive.


Diffs

* src/project/clipstabilize.cpp (3085f31)
* src/mainwindow.cpp (ba54164)

View Diff <https://git.reviewboard.kde.org/r/119095/diff/>

[Evert Vorster]

Hi there.

Tested, and the stabilizer works as advertised.

I would keep the other two stabilizers around for a while, there is no harm
in having a choice, is there? I suppose we could mark them as depreciated.

-Evert Vorster-

Post by Vincent PINON
Hello,
Sorry for the late reaction;
Patch applied to activate vid.stab, on git master (stable) branch.
Please test and comment ; do we need to keep older stab filters ? (for
projects compatibility)
BR,
Vincent
-------- Message original -------- Sujet: Review Request 119095: GUI
Added the vid.stab video stabilizer as a menu option. Date : Thu, 03 Jul
https://git.reviewboard.kde.org/r/119095/
Review request for Vincent Pinon.
By Steve Guilford.
*Repository: * kdenlive
Description
GUI Added menu option for new video stabilizer "vid.stab". Duplicated screen for videostab2 stabilizer for use with vid.stab.
Testing
Tested w/ current dev branch of Kdenlive.
Diffs
- src/project/clipstabilize.cpp (3085f31)
- src/mainwindow.cpp (ba54164)
View Diff <https://git.reviewboard.kde.org/r/119095/diff/>
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Kdenlive-devel mailing list
https://lists.sourceforge.net/lists/listinfo/kdenlive-devel

[Steinar H. Gunderson]

Post by Evert Vorster
I would keep the other two stabilizers around for a while, there is no harm
in having a choice, is there?

I keep seeing too many people think this way, and yes indeed, there is harm
in having a choice. It is not a meaningful choice to users; how would they
know which one to choose? And it means more code to be maintained, more
clutter in the UI, and more confusion. The user does not want three different
video stabilization filter, he/she just wants one that works. I would love if
free software would be better at realizing that choice fundamentally tends to
make people unhappy.

The only real argument for keeping them that I can see would be that we
shouldn't break existing projects without a good reason, but Dan has already
pointed out that removing them won't.

/* Steinar */

[Steve Guilford]

Here's the project file entries for a source and a stabilized clip.

<kdenlive_producer audio_max="53" id="1" pix_fmt="yuv420p"
default_video="0" fps="59.9401" analysisdata="" name="GOPR0122.MP4"
videocodecid="h264" colorspace="709" videocodec="H.264 / AVC / MPEG-4
AVC / MPEG-4 part 10"
resource="/storage/goodinfo/vids_n_things/GOPR0122.MP4"
default_audio="1" audiocodec="AAC (Advanced Audio Coding)"
duration="984" file_hash="234baf14588497b9d40ca2fc1697850b"
aspect_ratio="1" channels="2" frequency="48000" video_max="0"
progressive="1" type="3" frame_size="1280x720" file_size="32802998">
<metaproperty tool=""
name="meta.attr.0.stream.creation_time">2009-03-22 01:31:12</metaproperty>
<metaproperty tool="" name="meta.attr.0.stream.handler_name">
GoPro AVC</metaproperty>
<metaproperty tool=""
name="meta.attr.0.stream.language">eng</metaproperty>
<metaproperty tool=""
name="meta.attr.1.stream.creation_time">2009-03-22 01:31:12</metaproperty>
<metaproperty tool="" name="meta.attr.1.stream.handler_name">
GoPro AAC</metaproperty>
<metaproperty tool=""
name="meta.attr.1.stream.language">eng</metaproperty>
<metaproperty tool=""
name="meta.attr.compatible_brands">avc1isom</metaproperty>
<metaproperty tool="" name="meta.attr.creation_time">2009-03-22
01:31:12</metaproperty>
<metaproperty tool="" name="meta.attr.major_brand">avc1</metaproperty>
<metaproperty tool="" name="meta.attr.minor_version">0</metaproperty>
</kdenlive_producer>
<kdenlive_producer audio_max="53" duration="984" colorspace="709"
fps="59.9401" frame_size="1280x720" analysisdata=""
description="&quot;Stabilised&quot;" file_size="38981"
aspect_ratio="1" file_hash="fda51d56654936bd4c263d8e15427106" type="9"
id="2" name="GOPR0122.MP4.mlt" progressive="1"
resource="/storage/goodinfo/vids_n_things/GOPR0122.MP4.mlt">
<metaproperty tool=""
name="meta.attr.comment">"Stabilised"</metaproperty>
</kdenlive_producer>

I don't see any issues with removing the deprecated stabilizers.

Doing so will only take a few minutes. I'll take care of it in a day or
so...

Post by Evert Vorster
I would keep the other two stabilizers around for a while, there is no harm
in having a choice, is there?

I keep seeing too many people think this way, and yes indeed, there is harm
in having a choice. It is not a meaningful choice to users; how would they
know which one to choose? And it means more code to be maintained, more
clutter in the UI, and more confusion. The user does not want three different
video stabilization filter, he/she just wants one that works. I would love if
free software would be better at realizing that choice fundamentally tends to
make people unhappy.
The only real argument for keeping them that I can see would be that we
shouldn't break existing projects without a good reason, but Dan has already
pointed out that removing them won't.
/* Steinar */

[Dan Dennedy]

Post by Vincent PINON
Hello,
Sorry for the late reaction;
Patch applied to activate vid.stab, on git master (stable) branch.
Please test and comment ; do we need to keep older stab filters ? (for
projects compatibility)

I recommend to remove them. Removing them does not break older projects so
long as the MLT filters are still around. Keeping them only causes
confusion and causes people to use the deprecated ones up until their time
of removal. One can argue that "deprecated" is meant for developers, not
users.

If the Kdenlive UI provides a way to re-enter the stabilize options of a
stabilized clip, then perhaps you can make references to the old
stabilizers open the new UI.

Post by Vincent PINON
BR,
Vincent
-------- Message original -------- Sujet: Review Request 119095: GUI
Added the vid.stab video stabilizer as a menu option. Date : Thu, 03 Jul
https://git.reviewboard.kde.org/r/119095/
Review request for Vincent Pinon.
By Steve Guilford.
*Repository: * kdenlive
Description
GUI Added menu option for new video stabilizer "vid.stab". Duplicated screen for videostab2 stabilizer for use with vid.stab.
Testing
Tested w/ current dev branch of Kdenlive.
Diffs
- src/project/clipstabilize.cpp (3085f31)
- src/mainwindow.cpp (ba54164)
View Diff <https://git.reviewboard.kde.org/r/119095/diff/>
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Kdenlive-devel mailing list
https://lists.sourceforge.net/lists/listinfo/kdenlive-devel